✨ Don't lose last snapshot if last nl is missing ✨ #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because positron (and other editors) have an edit of trimming additional trailing newlines when saving. It probably would have been better to not write this in the first place, but I think we don't want to change that now as it will cause diffs to all snapshots, and only protects against a problem that happens rarely. Fixes #2092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because positron (and other editors) have an edit of trimming additional trailing newlines when saving. It probably would have been better to not write this in the first place, but I think we don't want to change that now as it will cause diffs to all snapshots, and only protects against a problem that happens rarely.
Fixes #2092